LibOSXUnwind 0.0.7 #2200
Merged
LibOSXUnwind 0.0.7 #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is identical to 0.0.6 except that it adds aarch64 support and sets julia_compat to 1.6
fingolfin
force-pushed
the
mh/LibOSXUnwind-0.0.7
branch
from
0d7db58 to
4462aa6
Compare
fingolfin
commented
Dec 1, 2020
|
|
||
| # Collection of sources required to build libosxunwind | ||
| sources = [ | ||
| ArchiveSource("https://github.com/JuliaLang/libosxunwind/archive/v$(version).tar.gz", | ||
| ArchiveSource("https://github.com/JuliaLang/libosxunwind/archive/v0.0.6.tar.gz", |
There was a problem hiding this comment.
This is not so nice; alternatives include: add a 0.0.7 tag to that repository; or switch to GitSource with a fixed sha1 (but is that better?)
There was a problem hiding this comment.
This is fine; it's how a lot of our stuff is going to be built in the future. The JLL version will be more independent from the upstream source version. :(
giordano
added
the
julia 💜 ❤️ 💚
|
@staticfloat please review? see also #2199 and discussion on #2190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to 0.0.6 except that it adds aarch64 support and sets julia_compat to 1.6
See discussion here.
CC @staticfloat.
Should only be merged after PR #2199 is closed (merged or rejected).