-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild libjulia+jll 1.5 with fixed libunwind linkage #2164
Rebuild libjulia+jll 1.5 with fixed libunwind linkage #2164
Conversation
More pointers: |
a084f39
to
414ba72
Compare
Using the |
sigh. of course. Anyway, I actually tried to just disable use of libunwind by setting |
Linking it statically instead seems to work here, i.e.:
(At least for the build, I have not tested the resulting library) |
Yeah, and disabling use of libunwind also works locally here... but not (yet?) in the BB file. I am playing with that right now, though |
Also upgrade to Julia 1.5.3 to fix macOS compile error related to rec_backtrace_ctx.
8cba338
to
31ce1d7
Compare
OK, using
But the static compilation trick suggested by @benlorenz seems to work, as in: the build completes and the resulting Testing this w/o just merging this PR is a bit of a pain, though; gotta build the JLL locally, then build the next JLL (see #2158) using the first one. Perhaps we can simply merge this PR (it shouldn't make anything worse, after all)? |
Do we need to verify that 1.3 and 1.4 still build with this change? |
Pushing Julia 1.3 and 1.4 here now to see if they still build |
06e964c
to
31ce1d7
Compare
Seems they all still build just fine. I've removed that HACk commit again. So yeah, this could be merged... @giordano ? |
The ultimate goal of this PR is to resolve the linker issue reported here based on the pointers by @benlorenz.
For now I just enabled
LibUnwind_jll
as a dependency to see what goes wrong, if anything. This can't be the final version, though, as we must also make sure not to break Julia 1.3 and 1.4.