Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ipopt] pin MUMPS_seq version #2162

Merged
merged 2 commits into from
Nov 23, 2020
Merged

[Ipopt] pin MUMPS_seq version #2162

merged 2 commits into from
Nov 23, 2020

Conversation

odow
Copy link
Contributor

@odow odow commented Nov 22, 2020

Ipopt fails tests with MUMPS_seq 5.3.5. As temporary hack, fix to 5.2.1.

x-ref: jump-dev/Ipopt.jl#243
cc @dpo

@odow odow mentioned this pull request Nov 22, 2020
Closed
@odow
Copy link
Contributor Author

odow commented Nov 22, 2020

Is it possible to get this merged ASAP? This is causing widespread issues throughout the JuMP ecosystem.

@giordano
Copy link
Member

I don't think this is the right fix, it's more likely that you need to pin OpenBLAS

@giordano
Copy link
Member

Do

]status -m

@odow
Copy link
Contributor Author

odow commented Nov 22, 2020

I tried pinning OpenBLAS32 to 0.3.10, the last version for which the tests passed: https://github.com/jump-dev/Ipopt.jl/runs/1420109426#step:6:42

This is definitely a MUMPS issue.

This fails

(Ipopt) pkg> status -m
Project Ipopt v0.6.3
Status `~/.julia/dev/Ipopt/Manifest.toml`
  [ae81ac8f] ASL_jll v0.1.1+4
  [56f22d72] Artifacts v1.3.0
  [6e4b80f9] BenchmarkTools v0.5.0
  [b99e7846] BinaryProvider v0.5.10
  [6e34b625] Bzip2_jll v1.0.6+5
  [523fee87] CodecBzip2 v0.7.2
  [944b1d66] CodecZlib v0.7.0
  [e66e0078] CompilerSupportLibraries_jll v0.3.4+0
  [cd3eb016] HTTP v0.8.19
  [83e8ac13] IniFile v0.5.0
  [9cc047cb] Ipopt_jll v3.13.2+0
  [692b3bcd] JLLWrappers v1.1.3
  [682c06a0] JSON v0.21.1
  [7d188eb4] JSONSchema v0.3.2
  [d00139f3] METIS_jll v5.1.0+5
  [d7ed1dd3] MUMPS_seq_jll v5.3.5+0
  [b8f27783] MathOptInterface v0.9.18
  [fdba3010] MathProgBase v0.7.8
  [739be429] MbedTLS v1.0.3
  [c8ffd9c3] MbedTLS_jll v2.16.8+1
  [d8a4904e] MutableArithmetics v0.2.12
  [656ef2d0] OpenBLAS32_jll v0.3.10+0
  [bac558e1] OrderedCollections v1.3.2
  [69de0a69] Parsers v1.0.12
  [3bb67fe8] TranscodingStreams v0.9.5
  [a5390f91] ZipFile v0.9.3
  [83775a58] Zlib_jll v1.2.11+18
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [b77e0a4c] InteractiveUtils
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [44cfe95a] Pkg
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA
  [9e88b42a] Serialization
  [6462fe0b] Sockets
  [2f01184e] SparseArrays
  [10745b16] Statistics
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode

This passes:

(Ipopt) pkg> st -m
Project Ipopt v0.6.3
Status `~/.julia/dev/Ipopt/Manifest.toml`
  [ae81ac8f] ASL_jll v0.1.1+4
  [56f22d72] Artifacts v1.3.0
  [6e4b80f9] BenchmarkTools v0.5.0
  [b99e7846] BinaryProvider v0.5.10
  [6e34b625] Bzip2_jll v1.0.6+5
  [523fee87] CodecBzip2 v0.7.2
  [944b1d66] CodecZlib v0.7.0
  [e66e0078] CompilerSupportLibraries_jll v0.3.4+0
  [cd3eb016] HTTP v0.8.19
  [83e8ac13] IniFile v0.5.0
  [9cc047cb] Ipopt_jll v3.13.2+0
  [692b3bcd] JLLWrappers v1.1.3
  [682c06a0] JSON v0.21.1
  [7d188eb4] JSONSchema v0.3.2
  [d00139f3] METIS_jll v5.1.0+5
  [d7ed1dd3] MUMPS_seq_jll v5.2.1+4
  [b8f27783] MathOptInterface v0.9.18
  [fdba3010] MathProgBase v0.7.8
  [739be429] MbedTLS v1.0.3
  [c8ffd9c3] MbedTLS_jll v2.16.8+1
  [d8a4904e] MutableArithmetics v0.2.12
  [656ef2d0] OpenBLAS32_jll v0.3.12+1
  [bac558e1] OrderedCollections v1.3.2
  [69de0a69] Parsers v1.0.12
  [3bb67fe8] TranscodingStreams v0.9.5
  [a5390f91] ZipFile v0.9.3
  [83775a58] Zlib_jll v1.2.11+18
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [b77e0a4c] InteractiveUtils
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [44cfe95a] Pkg
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA
  [9e88b42a] Serialization
  [6462fe0b] Sockets
  [2f01184e] SparseArrays
  [10745b16] Statistics
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode

@giordano
Copy link
Member

jump-dev/Ipopt.jl#242 refers to the fact you've got in your manifest a JLL package with one of the new architectures (aarch64-apple-darwin), this simply can't be MUMPS_seq. Not directly at least, maybe MUMPS_seq is pulling it. Besides, this PR does pin anything, the version specified is only used for building, not as compat in the registry (this needs to be better documented, it's a recent addition)

@odow
Copy link
Contributor Author

odow commented Nov 22, 2020 •
edited
Loading

Yes, the original issue in jump-dev/Ipopt.jl#242 is unrelated.

Besides, this PR does pin anything, the version specified is only used for building

I want Ipopt_jll to have a compat requiring [email protected]. What's the way to achieve that?

Edit: JuliaBinaryWrappers/Ipopt_jll.jl#1

@odow odow mentioned this pull request Nov 22, 2020
Closed
odow
odow commented Nov 22, 2020
View reviewed changes
I/Ipopt/build_tarballs.jl
@@ -47,8 +47,8 @@ products = [
# Dependencies that must be installed before this package can be built
dependencies = [
Dependency("ASL_jll"),
Dependency("OpenBLAS32_jll"), # Ipopt uses 32-bit ints
Dependency("MUMPS_seq_jll"),
Dependency("OpenBLAS32_jll", v"0.3.9"), # Ipopt uses 32-bit ints
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What 0.3.9 and not 0.3.10 or 0.3.12?

Copy link
Member

@giordano giordano Nov 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Julia version uses OpenBLAS 0.3.10, Julia v1.6 will use 0.3.12. Julia v1.5 uses OpenBLAS 0.3.9. If we're lucky and they're all ABI compatible the version doesn't really matter, but it's better to use the oldest version possible (at least the one used in the current stable Julia version)

@giordano giordano merged commit 83632b2 into JuliaPackaging:master Nov 23, 2020
@odow odow deleted the patch-1 branch April 14, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @giordano