-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libjulia 1.3.1 #1795
Add libjulia 1.3.1 #1795
Conversation
There is no libLLVM_jll 6.0.1 which complicates this, I guess... |
I might try using |
568bfb9
to
8dd66d5
Compare
Looking pretty good! Anybody got an idea what this might be about (from here):
|
47fc584
to
dae2c93
Compare
Something like ldc-developers/druntime@2f05aa1 diff --git a/src/rt/sections_elf_shared.d b/src/rt/sections_elf_shared.d
index df003d80c8..4076953bc4 100644
--- a/src/rt/sections_elf_shared.d
+++ b/src/rt/sections_elf_shared.d
@@ -910,7 +910,12 @@ struct tls_index
version(LDC)
{
- version(PPC64)
+ version(PPC)
+ {
+ extern(C) void* __tls_get_addr_opt(tls_index* ti);
+ alias __tls_get_addr = __tls_get_addr_opt;
+ }
+ else version(PPC64)
{
extern(C) void* __tls_get_addr_opt(tls_index* ti);
alias __tls_get_addr = __tls_get_addr_opt; might work. @vchuravy better ideas? |
We use Glibc 2.17 for PPC , this looks like LLVM at that point was build against 2.22. So likely we need to rebuild LLVM 6. |
That's a much more sensible observation 😅 |
Ok. I guess one could also try to create a libLLVM 6.0.1 instead? Not sure how much extra work that'd take, though? |
You can also skip PPC support for 1.3 |
I will skip the PowerPC builds then (although it's a bit of a pity, as it complicates the work on packages like libcxxwrap-julia if one wants to support as many platforms as possible: one has to very carefully match the platform selection in the various libjulia_jll variants. |
dae2c93
to
52e02e3
Compare
Can this be merged now? While I hope that perhaps we can eventually add back the powerpc support, this is stalled for the moment (see PR #1914), so it'd be nice to not hold this up for the sake of a fringe (no offense intended) platform. Unless you think it'll be "easy" to resolve the LLVM 6.0.1 build issue on macOS? |
No description provided.