Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libjulia 1.3.1 #1795

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin
Copy link
Member Author

There is no libLLVM_jll 6.0.1 which complicates this, I guess...

@fingolfin
Copy link
Member Author

I might try using LLVM_jll.jl 6.0.1

@fingolfin
Copy link
Member Author

Looking pretty good!

Anybody got an idea what this might be about (from here):

 /opt/powerpc64le-linux-gnu/bin/../powerpc64le-linux-gnu/sys-root/usr/local/lib/libLLVM-6.0.so: undefined reference to `__tls_get_addr_opt@GLIBC_2.22'

@fingolfin fingolfin marked this pull request as ready for review October 17, 2020 00:33
@giordano
Copy link
Member

Something like ldc-developers/druntime@2f05aa1

diff --git a/src/rt/sections_elf_shared.d b/src/rt/sections_elf_shared.d
index df003d80c8..4076953bc4 100644
--- a/src/rt/sections_elf_shared.d
+++ b/src/rt/sections_elf_shared.d
@@ -910,7 +910,12 @@ struct tls_index
 
 version(LDC)
 {
-    version(PPC64)
+    version(PPC)
+    {
+        extern(C) void* __tls_get_addr_opt(tls_index* ti);
+        alias __tls_get_addr = __tls_get_addr_opt;
+    }
+    else version(PPC64)
     {
         extern(C) void* __tls_get_addr_opt(tls_index* ti);
         alias __tls_get_addr = __tls_get_addr_opt;

might work. @vchuravy better ideas?

@vchuravy
Copy link
Member

We use Glibc 2.17 for PPC , this looks like LLVM at that point was build against 2.22. So likely we need to rebuild LLVM 6.

@giordano
Copy link
Member

That's a much more sensible observation 😅

@fingolfin
Copy link
Member Author

Ok. I guess one could also try to create a libLLVM 6.0.1 instead? Not sure how much extra work that'd take, though?

@vchuravy
Copy link
Member

You can also skip PPC support for 1.3

@fingolfin
Copy link
Member Author

I will skip the PowerPC builds then (although it's a bit of a pity, as it complicates the work on packages like libcxxwrap-julia if one wants to support as many platforms as possible: one has to very carefully match the platform selection in the various libjulia_jll variants.

@fingolfin
Copy link
Member Author

Can this be merged now? While I hope that perhaps we can eventually add back the powerpc support, this is stalled for the moment (see PR #1914), so it'd be nice to not hold this up for the sake of a fringe (no offense intended) platform. Unless you think it'll be "easy" to resolve the LLVM 6.0.1 build issue on macOS?

@giordano giordano merged commit debf649 into JuliaPackaging:master Oct 18, 2020
@fingolfin fingolfin deleted the mh/libjulia-1.3 branch October 18, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants