libCppInterOp: fix symbol visibility issues on Windows #10250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gnimuc
commented
Jan 12, 2025
•
Gnimuc
commented
- update patches
- retrigger build
giordano
reviewed
Jan 12, 2025
| From ce769c6e91730c753e30dfd072a3d991d87e4688 Mon Sep 17 00:00:00 2001 | ||
| From: Gnimuc <[email protected]> | ||
| Date: Sun, 12 Jan 2025 19:01:50 +0900 | ||
| Subject: [PATCH 2/2] Fix symbol visibility issues for C API |
There was a problem hiding this comment.
I presume this second patch should be upstreamed too?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ideally all patches except the cmake patch should be upstreamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.