Skip to content

Commit

Permalink
Remove various uses of const (#2319)
Browse files Browse the repository at this point in the history
They are not useful but make it harder to compose the .jl files.

[skip build]
[skip ci]
  • Loading branch information
fingolfin authored Dec 29, 2020
1 parent ff4399b commit 95e9c06
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion L/libcxxwrap_julia/build_tarballs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ julia_version = v"1.5.3"
name = "libcxxwrap_julia"
version = v"0.8.5"

const is_yggdrasil = haskey(ENV, "BUILD_BUILDNUMBER")
is_yggdrasil = haskey(ENV, "BUILD_BUILDNUMBER")
git_repo = is_yggdrasil ? "https://github.com/JuliaInterop/libcxxwrap-julia.git" : joinpath(ENV["HOME"], "src/julia/libcxxwrap-julia/")
unpack_target = is_yggdrasil ? "" : "libcxxwrap-julia"

Expand Down
12 changes: 6 additions & 6 deletions L/libsingular_julia/common.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ using BinaryBuilder
import Pkg: PackageSpec
import Pkg.Types: VersionSpec

const name = "libsingular_julia"
const version = VersionNumber(0, 4, julia_version.minor)
name = "libsingular_julia"
version = VersionNumber(0, 4, julia_version.minor)

# Collection of sources required to build libsingular-julia
const sources = [
sources = [
GitSource("https://github.com/oscar-system/libsingular-julia.git", "b63a76c1634dc680485f5b7d4c81235e39d714bd"),
]

# Bash recipe for building across all platforms
const script = raw"""
script = raw"""
cd libsingular-julia
cmake . -B build \
-DJulia_PREFIX="$prefix" \
Expand All @@ -37,12 +37,12 @@ platforms = filter!(!Sys.iswindows, platforms) # Singular does not support Windo
platforms = expand_cxxstring_abis(platforms)

# The products that we will ensure are always built
const products = [
products = [
LibraryProduct("libsingular_julia", :libsingular_julia),
]

# Dependencies that must be installed before this package can be built
const dependencies = [
dependencies = [
BuildDependency(PackageSpec(name="libjulia_jll", version=julia_version)),
Dependency("libcxxwrap_julia_jll"),
Dependency(PackageSpec(name="Singular_jll", version=VersionSpec("402.000"))),
Expand Down
2 changes: 1 addition & 1 deletion L/libsingular_julia/[email protected]/build_tarballs.jl
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
const julia_version = v"1.3.1"
julia_version = v"1.3.1"
include("../common.jl")

2 changes: 1 addition & 1 deletion L/libsingular_julia/[email protected]/build_tarballs.jl
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
const julia_version = v"1.4.2"
julia_version = v"1.4.2"
include("../common.jl")
2 changes: 1 addition & 1 deletion L/libsingular_julia/[email protected]/build_tarballs.jl
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
const julia_version = v"1.5.3"
julia_version = v"1.5.3"
include("../common.jl")

0 comments on commit 95e9c06

Please sign in to comment.