Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 08 compat #29

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Version 08 compat #29

merged 4 commits into from
Sep 17, 2019

Conversation

lassepe
Copy link
Member

@lassepe lassepe commented Sep 17, 2019

@zsunberg: what should happen with currentobs and history for the particle beliefs here. I don't see a straight forward way of implementing these with the current design. Should I just not implement them?

@lassepe lassepe requested a review from zsunberg September 17, 2019 18:37
@zsunberg
Copy link
Member

Yeah, just leave out history and currentobs if the beliefs don't contain what you need.

zsunberg
zsunberg approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@zsunberg zsunberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@zsunberg zsunberg merged commit 44b494e into master Sep 17, 2019
@zsunberg zsunberg deleted the version-08-compat branch September 17, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsunberg zsunberg zsunberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lassepe @zsunberg