Minor refactoring of DPW so the code structure is more consistent #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with the vanilla version.
zsunberg
requested changes
Nov 29, 2021
There was a problem hiding this comment.
Thanks for the contribution!
The main change of moving the node selection into functions looks good. However, there are a lot of other changes not related to this in the PR.
In particular, please remove the additional time check before we merge this since we haven't determined whether it is necessary.
(I realize that it is a bit of a pain to do this, but in the long run, simple, atomic, pull requests that address one issue will make maintenance much better!)
|
Awesome! Thanks. This looks good. |
|
Thanks a lot for the quick reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More consistent with the vanilla MCTS code, that is.
In particular, moved out the action selection logic to separate methods.