Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sinkhorn_divergence to runtests #146

Merged
merged 4 commits into from
Sep 22, 2021
Merged

add sinkhorn_divergence to runtests #146

merged 4 commits into from
Sep 22, 2021

Conversation

zsteve
Copy link
Member

@zsteve zsteve commented Sep 22, 2021

I am clearly a donkey and didn't include sinkhorn_divergence in runtests.jl (the tests all pass, though).
will merge directly

@coveralls
Copy link

coveralls commented Sep 22, 2021

Pull Request Test Coverage Report for Build 1261110903

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+10.0%) to 95.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils.jl 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/utils.jl 1 95.35%
Totals Coverage Status
Change from base Build 1260631313: 10.0%
Covered Lines: 590
Relevant Lines: 619

💛 - Coveralls

Project.toml Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
test/entropic/sinkhorn_divergence.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #146 (cee80a6) into master (803274d) will increase coverage by 10.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #146       +/-   ##
===========================================
+ Coverage   85.27%   95.31%   +10.03%     
===========================================
  Files          14       14               
  Lines         618      619        +1     
===========================================
+ Hits          527      590       +63     
+ Misses         91       29       -62     
Impacted Files Coverage Δ
src/utils.jl 95.34% <100.00%> (+2.32%) ⬆️
src/entropic/symmetric.jl 96.42% <0.00%> (+96.42%) ⬆️
src/entropic/sinkhorn_divergence.jl 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803274d...cee80a6. Read the comment docs.

@zsteve zsteve marked this pull request as ready for review September 22, 2021 10:34
@zsteve zsteve merged commit 59223df into master Sep 22, 2021
@zsteve zsteve deleted the fix_test branch September 22, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants