Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some maintenance #156

Merged
merged 3 commits into from
Aug 26, 2024
Merged

some maintenance #156

merged 3 commits into from
Aug 26, 2024

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Jul 2, 2024

New feature of the setup-julia action: should be less noisy than nightly :)

@aplavin
Copy link
Member Author

aplavin commented Jul 2, 2024

Oh, currently pre also fails :) I think JuliaLang/julia#52986 + JuliaLang/julia#54664 is still unresolved for 1.11, so let's wait for now...

@aplavin aplavin changed the title add pre to CI some maintenance Aug 25, 2024
@aplavin
Copy link
Member Author

aplavin commented Aug 25, 2024

Even though pre is still failing, I think it would be useful to add it anyway – for the future.
Also, new commit fixes JuliaObjects/ConstructionBaseExtras.jl#7.

Will merge soon if noone is against.

Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice lgtm

@aplavin aplavin merged commit a5166b7 into JuliaObjects:master Aug 26, 2024
6 of 10 checks passed
@aplavin aplavin deleted the pre branch August 27, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants