Code

simplify types#23

Code

Merged

rkurchin merged 22 commits intomasterJuliaMolSim/AtomsBase.jl:masterfrom less_abstractJuliaMolSim/AtomsBase.jl:less_abstractCopy head branch name to clipboardNov 17, 2021

+226-202

Commits

Commits on Nov 10, 2021

• first, just get rid of AbstractElement

  Show description for c7e8097
  rkurchin

  committed
  c7e8097

  Copy full SHA for c7e8097

• oops, deleted export of AbstractParticle and AbstractAtom in first commit, put them back

  Show description for a615a79
  rkurchin

  committed
  a615a79

  Copy full SHA for a615a79

• remove AbstractParticle, keep SimpleAtom for now

  Show description for fede982
  rkurchin

  committed
  fede982

  Copy full SHA for fede982

• and now AbstractSystem is gone too

  Show description for 7a32c77
  rkurchin

  committed
  7a32c77

  Copy full SHA for 7a32c77

Commits on Nov 12, 2021

• Revert "and now AbstractSystem is gone too"

  Show description for 56eea33
  rkurchin

  committed
  56eea33

  Copy full SHA for 56eea33

• remove export of ChemicalElement

  Show description for ce9ac5b
  rkurchin

  committed
  ce9ac5b

  Copy full SHA for ce9ac5b

• remove duplicated iterate dispatch

  Show description for 87d9c23
  rkurchin

  committed
  87d9c23

  Copy full SHA for 87d9c23

• rename SimpleAtom to StaticAtom, delete phantom implementation_simple file that somehow came back

  Show description for bfcff94
  rkurchin

  committed
  bfcff94

  Copy full SHA for bfcff94

• rename element function to species, add "singular" species function, fix return types of other singular functions, rename ET parameter to S, add default size dispatch since firstindex default to a …

  Show description for 47ae467
  rkurchin

  committed
  47ae467

  Copy full SHA for 47ae467

• fix iterate

  Show description for 95c1997
  rkurchin

  committed
  95c1997

  Copy full SHA for 95c1997

• readme updates, a couple other small fixes

  Show description for b9bc083
  rkurchin

  committed
  b9bc083

  Copy full SHA for b9bc083

• printing tweaks

  Show description for 8e17ad8
  rkurchin

  committed
  8e17ad8

  Copy full SHA for 8e17ad8

• Michael's suggested change for typing on box

  Show description for 4aca49f
  rkurchin

  committed
  4aca49f

  Copy full SHA for 4aca49f

• move atomic stuff to another file, fix some broken functions

  Show description for 9f9743f
  rkurchin

  committed
  9f9743f

  Copy full SHA for 9f9743f

• rename get_periodic, add tests

  Show description for 13db820
  rkurchin

  committed
  13db820

  Copy full SHA for 13db820

• add docstrings

  Show description for 89a68ba
  rkurchin

  committed
  89a68ba

  Copy full SHA for 89a68ba

• formatting

  Show description for 9f6d7bf
  rkurchin

  committed
  9f6d7bf

  Copy full SHA for 9f6d7bf

Commits on Nov 16, 2021

• few tweaks per G's suggestions

  Show description for 9a01ba9
  rkurchin

  committed
  9a01ba9

  Copy full SHA for 9a01ba9

Commits on Nov 17, 2021

• mostly aesthetic changes per Michael's suggestions

  Show description for 54a0a8d
  rkurchin

  committed
  54a0a8d

  Copy full SHA for 54a0a8d

• add indexed versions of position, velocity, species fcns

  Show description for 456a4fe
  rkurchin

  committed
  456a4fe

  Copy full SHA for 456a4fe

• add tests, fix typo in SoA implementation

  Show description for 0cb1b23
  rkurchin

  committed
  0cb1b23

  Copy full SHA for 0cb1b23

• remove getindex and length error throws, leaving boundary_conditions and bounding_box for now since there are type annotations...

  Show description for f0896f8
  rkurchin

  committed
  f0896f8

  Copy full SHA for f0896f8