allow CUDA 4 #115
Merged
allow CUDA 4 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 9 9
Lines 1116 1116
=======================================
Hits 988 988
Misses 128 128 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
makes sense, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows CUDA.jl version 4. The main change is in that in CUDA 4,
CUDA.functional()always returns false during precompilation, so the current thing doens't work (the package would load as empty). In any case, I don't think checkingCUDA.functional()is the recommended thing even in prior versions, since CUDA will always load, so you can just define your functions regardless if later its loaded somewhere with or without functional CUDA.