-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement precompute = POLYNOMIAL
for blocking = false
#94
Comments
The release ist triggered. Regarding the other implementation: I will give this a go once I find some time. Want to have this for completeness anyway. If it will help in your case is not 100% clear. Depends on the fraction, the precomputation right now takes. |
I gave this a go. If you plan to benchmark it would be great to do this in a systematic way. I would be in particular interested in the impact on precomputation and runtime. I expect almost zero precomputation cost. The runtime should not change for small |
Many thanks! Not sure along which axes of the large parameter space you want me to run systematic benchmarks. In my real world example, with the default settings |
What would be interesting is:
|
This feature is implemented |
Thanks, @tknopp for the comments in #93! Indeed, for calling
calculateToeplitzKernel!
repeatedly, the settingsprecompute = LINEAR, blocking = false
are the fastest. Hence, it would be awesome to have an implementation forprecompute = POLYNOMIAL, blocking = false
, if you say this faster!Off topic: Many thanks for your prompt merging / fixing the other issues! Would you mind releasing the patch to make it easier to incorporate the bugfixes?
The text was updated successfully, but these errors were encountered: