-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GriddedInterpolation for non-uniform grids #56
Conversation
OK, I think this is ready to go. Testing could probably be better, but this is a good start. |
interpolate!{IT<:DimSpec{BSpline},GT<:DimSpec{GridType}}(A::AbstractArray{Rational{Int}}, ::Type{IT}, ::Type{GT}) = interpolate!(Rational{Int}, A, IT, GT) | ||
function interpolate!{IT<:DimSpec{BSpline},GT<:DimSpec{GridType}}(A::AbstractArray, ::Type{IT}, ::Type{GT}) | ||
interpolate!(tweight(A), A, IT, GT) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice refactoring! 👍
This is really nice! Re: testing, what is the expected behavior when the knots are actually Also, we should start some feature-matrix somewhere, that indicates what features (interpolation degrees, gradient evaluation etc) that are implemented in the different interpolation schemes. |
Good suggestion. This caught what could have been an embarrassing bug. |
Add GriddedInterpolation for non-uniform grids
I was looking into doing a benchmark against other packages, and the lack of this feature made the comparisons pretty unfair. So I decided to add it. This was one of those days where one marvels at the efficiency of Julia.
I haven't done extensive testing or benchmarking, hence the WIP.