remove unbound type parameters #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't check, but unbound type parameters often cause performance issues, so this may not be merely cosmetic.
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 87.10% 87.10%
=======================================
Files 28 28
Lines 1846 1846
=======================================
Hits 1608 1608
Misses 238 238
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Looks good to me, thanks. Did you have a way for screening for these automatically? |
Try nightly Julia: JuliaLang/julia#46608 |
|
I'm going to merge this, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't check, but unbound type parameters often cause performance issues, so this may not be merely cosmetic.