Change the default arithmetic of *
for Normed
to wrapping
#236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of multiplication for
Normed
was changed in PR #213, but its arithmetic defaulted to checked arithmetic for backward compatibility.Although the discussion in Discourse is not aimed solely at building specific consensus, but at least, there is no objection to changing the default arithmetic of multiplication for
Normed
to wrapping arithmetic (i.e. Option 2.).So this PR changes the default arithmetic to wrapping. This increases the risk of not noticing the overflow, but improves the consistency of the arithmetic rules.
You can still use checked arithmetic explicitly.