Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] use Github Actions and update test targets #204

Merged
merged 3 commits into from
Jul 21, 2020
Merged

[CI] use Github Actions and update test targets #204

merged 3 commits into from
Jul 21, 2020

Conversation

johnnychen94
Copy link
Collaborator

This follows the discussion in #203

  • move CI workloads to Github Actions
  • remove windows 32bit and say goodbye to appveyor
  • test aarch64 for Julia 1.0, 1, and nightly in travis
  • add linux 32bit for Julia 1

@johnnychen94
[CI] use Github Actions and update test targets
3c17b03 
* move CI workloads to Github Actions
* remove windows 32bit and say goodbye to appveyor
* test aarch64 for Julia 1.0, 1, and nightly in travis
* add linux 32bit for Julia 1
johnnychen94
johnnychen94 commented Jul 21, 2020
View reviewed changes
.github/workflows/UnitTest.yml
test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Copy link
Collaborator Author

@johnnychen94 johnnychen94 Jul 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for this is true.

If I get it correctly, Github Action currently doesn't support allow_failure, so it would be nice to disable this to keep all jobs running.

kimikage
kimikage approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@kimikage kimikage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The errors on ARM should be fixed by #201 and #203. We need to remove the webhook for AppVeyor as with JuliaGraphics/Colors.jl#433.
@timholy, can you please kindly help me?

@timholy
Copy link
Member

timholy commented Jul 21, 2020

Both webhooks removed. Thanks for tackling this!

@kimikage
Copy link
Collaborator

To make sure #201 and #203 work, I'll merge this first.
Generally, we should write test_brokens, but I will omit them. Regarding the failures on ARM, I think we can tolerate them depending on their importance, as long as the compilation succeeds. On the other hand, allow_failure should not be set to prevent oversight of errors.

@kimikage kimikage merged commit c5909c8 into JuliaMath:master Jul 21, 2020
@johnnychen94 johnnychen94 deleted the jc/ci branch July 21, 2020 21:30
@kimikage
Copy link
Collaborator

@timholy, we are still using travis-ci.org. Why not move to travis-ci.com?

@johnnychen94
Copy link
Collaborator Author

johnnychen94 commented Jul 24, 2020 •
edited
Loading

For public projects, there seems no difference. We could do the switch when there's real trouble using it; it doesn't affect users so it's of less importance IMO.

@kimikage kimikage mentioned this pull request Sep 10, 2020
Merged
@kimikage
Copy link
Collaborator

kimikage commented Nov 5, 2020

I didn't expect the pricing model change before the the migration deadline. 😅

I can't predict how much of a hassle it will be to re-request credits, but should we migrate to .com first?

@kimikage kimikage mentioned this pull request Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimikage kimikage kimikage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnnychen94 @timholy @kimikage