-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isinteger(::Normed) incorrect #120
Comments
This looks good (though I don't quite understand the magic shifting operations here), could you open a PR on this? Thanks |
johnnychen94
added a commit
to johnnychen94/FixedPointNumbers.jl
that referenced
this issue
May 15, 2019
fixes JuliaMath#120 : `isinteger(1N0f8)` should be true
johnnychen94
added a commit
to johnnychen94/FixedPointNumbers.jl
that referenced
this issue
May 15, 2019
fixes JuliaMath#120 : `isinteger(1N0f8)` should be true
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code currently assumes that the denominator is
2^f
, which is not the case forNormed
. e.g.I believe you need to change
to
The text was updated successfully, but these errors were encountered: