Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiffEqFlux Blog Post #274

Merged
merged 61 commits into from
Jan 23, 2019
Merged

DiffEqFlux Blog Post #274

merged 61 commits into from
Jan 23, 2019

Conversation

ChrisRackauckas
Copy link
Member

Two discussion points from the private channels which are still un-addressed:

  • diffeq_rd is explained long before its use. Example should probably come first?
  • 100 epochs of training without data is admittedly odd.

@ChrisRackauckas
Copy link
Member Author

Adding in the media next.

@MikeInnes
Copy link
Member

Maybe it's better to just write out the loop rather than using train!. Being able to use that is kind of neat but probably less clear overall.

@ChrisRackauckas
Copy link
Member Author

ChrisRackauckas commented Jan 18, 2019

Some media:

lv_sol

data_points

rober_plot

@ChrisRackauckas
Copy link
Member Author

Needs JuliaDiff/ForwardDiff.jl#378 and a ForwardDiff tag @jrevels

@KristofferC
Copy link
Member

KristofferC commented Jan 18, 2019

That PR still fails tests.

@ChrisRackauckas
Copy link
Member Author

Yes, which is a great reason to ping for help.

@ChrisRackauckas
Copy link
Member Author

SciML/DelayDiffEq.jl#93 breaks the layer because of the sizing issue. Temporary fix:

function delay_lotka_volterra(du,u,h,p,t)
  x, y = u
  α, β, δ, γ = p
  du[1] = dx =- β*y)*h(p,t-0.1)[1]
  du[2] = dy =*x - γ)*y
end
h(p,t) = ones(eltype(p),2)
prob = DDEProblem(delay_lotka_volterra,[1.0,1.0],h,(0.0,10.0),constant_lags=[0.1])
p = param([2.2, 1.0, 2.0, 0.4])
params = Flux.Params([p])
reduction2(sol) = sol[1,1:101]
function predict_fd_dde()
  diffeq_fd(p,reduction2,101,prob,MethodOfSteps(Tsit5()),saveat=0.1)
end
loss_fd_dde() = sum(abs2,x-1 for x in predict_fd_dde())
loss_fd_dde()

@ChrisRackauckas
Copy link
Member Author

ChrisRackauckas commented Jan 18, 2019

neural_ode_fit

neural_sde_fit

@ChrisRackauckas ChrisRackauckas changed the title FluxDiffEq Blog Post DiffEqFlux Blog Post Jan 18, 2019
Copy link
Contributor

@jessebett jessebett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments.

Copy link
Contributor

@jessebett jessebett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More suggestions, mostly typos

* Fixed NeurIPS acronym

* RNN -> ResNet
@ChrisRackauckas
Copy link
Member Author

Here's a Gist with the code. It may make sense to link this in the post somewhere.

https://gist.github.com/ChrisRackauckas/89bb4181bb1c82266daeeec68c7f8d0e

@ChrisRackauckas
Copy link
Member Author

Following @ViralBShah 's suggestion, we put the runnable scripts in the model-zoo repo and will link to them after each animation to make it easier to follow along with the post. @MikeInnes will get that merged in a sec, add the links here, and then we are ready to release. So let's say 10:30-11? Any last comments need to get in by then, or at least highlight a previous discussion.

@ChrisRackauckas ChrisRackauckas merged commit 76b13fa into master Jan 23, 2019
@ChrisRackauckas ChrisRackauckas deleted the fluxdiffeq_post branch January 23, 2019 15:45
@fredrikekre
Copy link
Member

The title seems to be missing from the rendered version.

@ChrisRackauckas
Copy link
Member Author

@MikeInnes
Copy link
Member

I just fixed it, hopefully it'll show up soon.

@jekbradbury
Copy link
Contributor

jekbradbury commented Jan 23, 2019

The LaTeX isn’t showing up for me in mobile Safari
73df2982-1e94-41b4-8bac-0bc32362b86c
I think you need to include MathJax at the top of the post, like this?

@Vaibhavdixit02
Copy link
Contributor

Vaibhavdixit02 commented Jan 23, 2019

The LateX isn't working in desktop Safari as well

@ChrisRackauckas
Copy link
Member Author

49ba1b2 should fix it when the post updates

@ChrisRackauckas
Copy link
Member Author

we should be good. Still taking any hotfixes as they come, but it's good to post now I think

@fredrikekre
Copy link
Member

fredrikekre commented Jan 23, 2019

I think 49ba1b2 broke this:
screenshot from 2019-01-23 17-22-33

Edit: No, it is just a missing \end{align}.

@AzamatB
Copy link

AzamatB commented Jan 25, 2019

In some formulas derivative sign is not typeset correctly. For example:
screen shot 2019-01-25 at 11 55 07 am

@oxinabox
Copy link
Contributor

Probably need to switch ' for ^\prime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.