Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move protective comment closer to the content it refers to [nfc] #1977

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

LilithHafner
Copy link
Member

This disclaimer was moved to the top and comment added in #1432 cc @StefanKarpinski
And then the note was moved to the bottom without the comment in #1456 cc @ViralBShah

The disclaimer and comment should be together. If it's unlawful to have the note at the bottom, then the comment should say so. I'm not a lawyer this isn't legal advice.

Copy link

github-actions bot commented Dec 4, 2023

Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR1977/ in ~15 minutes

@LilithHafner LilithHafner changed the title Move protective comment closer to the content it refers to Move protective comment closer to the content it refers to [nfc] Dec 4, 2023
@ViralBShah ViralBShah merged commit a18f9a0 into main Dec 4, 2023
@ViralBShah ViralBShah deleted the lh/move-comment branch December 4, 2023 22:50
@StefanKarpinski
Copy link
Member

Yeah, was originally right above but, of course, got ignored when someone moved the notification about IP addresses 😂😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants