Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner downloads table #1770

Closed
wants to merge 6 commits into from
Closed

Cleaner downloads table #1770

wants to merge 6 commits into from

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 30, 2022 •
edited
Loading

Just an idea. Treats it more like a table, removes repetition.

The other tables need updating if approved of

This PR

Screen Shot 2022-10-30 at 12 05 08 PM

vs main

Screen Shot 2022-10-30 at 12 05 59 PM

@github-actions
Copy link

Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR1770/ in ~15 minutes

@IanButterworth IanButterworth force-pushed the ib/format_downloads_table branch from 6a7ca60 to 70a9302 Compare October 30, 2022 16:22
DilumAluthge
DilumAluthge approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should preserve the text aarch64 (for Linux ARM 64-bit), but otherwise LGTM.

@logankilpatrick
Copy link
Member

@IanButterworth this looks good to me, I am happy to proceed with a merge if you think it's good to go.

@IanButterworth
Copy link
Member Author

The other tables need updating before merge.

@logankilpatrick
Copy link
Member

One piece of feedback, maybe we can add a sentence somewhere that says what "archive" means in this context, I genuinely don't know what it is.

@logankilpatrick
Copy link
Member

Are you willing/able to do that as well? If not, I can take a stab this week sometime.

@IanButterworth IanButterworth force-pushed the ib/format_downloads_table branch from ab6006f to 3f886a8 Compare November 24, 2022 04:29
@IanButterworth IanButterworth force-pushed the ib/format_downloads_table branch from 3f886a8 to 7b27a9c Compare November 24, 2022 04:31
@logankilpatrick
Copy link
Member

@IanButterworth Are we good to merge this?

@logankilpatrick logankilpatrick marked this pull request as ready for review December 22, 2022 15:00
@IanButterworth
Copy link
Member Author

The other tables need updating before merge.

Please feel free to do this and push here. I think they should all match in format.

@ViralBShah
Copy link
Member

I agree we should not use the word archive. Most people don't know what it means.

@logankilpatrick
Copy link
Member

I can take this PR over the finish line, but what do we want "Archive" to say? It is unclear to me what that means here.

@ViralBShah
Copy link
Member

I suggest just updating this and we can wordsmith later.

LilithHafner added a commit that referenced this pull request Dec 4, 2023
@LilithHafner
Factor out "xx-bit" in downloads table (subset of #1770)
af7cd4d
@LilithHafner LilithHafner mentioned this pull request Dec 4, 2023
Merged
LilithHafner added a commit that referenced this pull request Dec 7, 2023
@LilithHafner
Factor out "xx-bit" in downloads table (subset of #1770) (#1978)
656d36e
@IanButterworth IanButterworth deleted the ib/format_downloads_table branch December 7, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge Awaiting requested review from DilumAluthge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IanButterworth @logankilpatrick @ViralBShah @DilumAluthge @LilithHafner