Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog doesn't render on localhost #969

Closed
ViralBShah opened this issue Aug 24, 2020 · 6 comments · Fixed by #970
Closed

Blog doesn't render on localhost #969

ViralBShah opened this issue Aug 24, 2020 · 6 comments · Fixed by #970

Comments

@ViralBShah
Copy link
Member

@tlienart When I run the Franklin server locally to test, the blog doesn't work right. Only the Julia-1.5 highlights post and the Yao post can be clicked on localhost:8000. The rest all say that the page does not exist.

But everything works fine on julialang.org.

@tlienart
Copy link
Contributor

tlienart commented Aug 24, 2020

am having a look now.

Edit: ok no, am on the move with only mobile data and for some reason recent updates seem to have added hundreds of MB on the repo 😞 I'll look into this tmrw when I have a fast connection.

In the meantime; what version of Franklin are you using? can you try 0.8 and see whether it works better? I don't think I introduced anything breaking though but maybe I did something stupid...

also assuming this is reproducible and it's a bug in Franklin; people should hold off merging anything to avoid triggering a rebuild of the site that would mess things up... if that's the case, you can always patch things up by just forcing the version to be 0.8 in the deploy script.

@ViralBShah
Copy link
Member Author

I also noticed the website pulling in a bunch of stuff. I have been just doing simple PR merging for the most part. I did update to Franklin 0.9, which may be where I am seeing this. Maybe the deployment is unaffected because it is on the older version.

@tlienart
Copy link
Contributor

I can reproduce; it's a bug. I'll try to fix it asap once I've figured out what's going on. thanks for reporting and apologies for the nuisance... good that the deploy is fixed on 0.8 atm

@tlienart
Copy link
Contributor

Is fixed in 0.9.10; will open and merge directly a PR that does a slight update of the scripts here.

@ViralBShah
Copy link
Member Author

ViralBShah commented Aug 25, 2020

Thanks for the quick fix. Should we deploy 0.9.10 to production as well?

@tlienart
Copy link
Contributor

it's already done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants