-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate completions #753
generate completions #753
Conversation
I'm not really familiar with how completion files work. Do we need to drop them into a specific location on user systems? Or do they need to be run? Or something else? |
Packages usually install their zsh completions to So OS repositories (Arch User Repository, openSUSE Tumbleweed, Solus) should definitely package the completions into these directories. For the "recommended" install method
we are only the local user. We could put the completions somewhere in Line 790 in a9d6755
$PATH . => We can add our completions directory to the specific shell completions.
Though personally I'm not a fan of fishing around in people's config files. I think we should do it the way rustup does it.
for bash, for example. |
I have now followed the rustup way, and added a command that generates the completions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Looks good to me, and is quite useful!
@BoostCookie unfortunately it seems this now as conflicts that must be resolved? |
Is there even any interest in this pull request? |
Yes, this is great functionality. @davidanthoff is quite busy, but please don't be discouraged. We'll get this merged. |
We had more changes to the clap structures on @BoostCookie could you rebase this PR on top of Awesome PR, thanks! |
The command generates the shell completions file for juliaup. For example, to generate the completions for Bash and save them to a file you can run ``` juliaup completions bash > ~/.local/share/bash-completion/completions/juliaup ``` Then you can source this file in your bashrc.
EDIT:
This is done now. It solves #151. It works the same way as it does in rustup. https://rust-lang.github.io/rustup/installation/index.html
OLD MESSAGE: