Add timing when PRECOMPILE_TRACE_COMPILE is set
#57251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
👍 Thanks, this makes sense to me.
Let's collect input from maybe @IanButterworth and @KristofferC as well?
|
Weird.. I already did this once #54962 |
|
It was undone here: #56214 Do you think it was just a mistaken merge conflict? |
|
Yeah I'd guess so. |
IanButterworth
approved these changes
Feb 4, 2025
IanButterworth
added
the
merge me
kpamnany
added a commit
to RelationalAI/julia
that referenced
this pull request
Feb 4, 2025
3 tasks
kpamnany
added a commit
to RelationalAI/julia
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could add yet another environment variable to control this if preferred, but IMO this works.