Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xref UnionAll in the doc string of where #56411

Merged
merged 1 commit into from
Dec 15, 2024
Merged

xref UnionAll in the doc string of where #56411

merged 1 commit into from
Dec 15, 2024

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Nov 1, 2024

No description provided.

@nsajko nsajko added docs This change adds or pertains to documentation types and dispatch Types, subtyping and method dispatch labels Nov 1, 2024
@nsajko
Copy link
Contributor Author

nsajko commented Nov 1, 2024

Apart from cross-referencing UnionAll, the goal here is to prevent confusion with Union, which often happens to newcomers due to the "iterated union" phrasing.

@nsajko nsajko added backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Nov 1, 2024
@nsajko
Copy link
Contributor Author

nsajko commented Nov 6, 2024

bump

@KristofferC KristofferC mentioned this pull request Nov 11, 2024
Merged
47 tasks
This was referenced Nov 22, 2024
Merged
Merged
@nsajko nsajko force-pushed the doc_where_UnionAll branch from b4efd4e to 60a609d Compare November 23, 2024 08:17
@nsajko
Copy link
Contributor Author

nsajko commented Nov 23, 2024

ping

@KristofferC KristofferC mentioned this pull request Dec 3, 2024
Merged
51 tasks
@nsajko nsajko force-pushed the doc_where_UnionAll branch from 60a609d to 60d94d6 Compare December 3, 2024 23:55
@nsajko
Copy link
Contributor Author

nsajko commented Dec 4, 2024

bump

@nsajko nsajko force-pushed the doc_where_UnionAll branch from 60d94d6 to f0cf85b Compare December 9, 2024 19:13
@nsajko nsajko added the merge me PR is reviewed. Merge when all tests are passing label Dec 15, 2024
@nsajko
Copy link
Contributor Author

nsajko commented Dec 15, 2024

merge?

@inkydragon inkydragon merged commit 8924e6f into JuliaLang:master Dec 15, 2024
6 of 8 checks passed
@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Dec 15, 2024
@nsajko nsajko deleted the doc_where_UnionAll branch December 15, 2024 18:36
KristofferC pushed a commit that referenced this pull request Jan 2, 2025
@nsajko
xref UnionAll in the doc string of where (#56411)
2f3f27e 
(cherry picked from commit 8924e6f)
KristofferC pushed a commit that referenced this pull request Jan 2, 2025
@nsajko
xref UnionAll in the doc string of where (#56411)
5b83838 
(cherry picked from commit 8924e6f)
stevengj pushed a commit that referenced this pull request Jan 2, 2025
@nsajko @stevengj
xref UnionAll in the doc string of where (#56411)
6f97eb8
KristofferC pushed a commit that referenced this pull request Jan 13, 2025
@nsajko
xref UnionAll in the doc string of where (#56411)
e62a06c 
(cherry picked from commit 8924e6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees
No one assigned
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 docs This change adds or pertains to documentation types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsajko @oscardssmith @inkydragon