Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle async termination better #55440

Merged
merged 1 commit into from
Aug 15, 2024
Merged

handle async termination better #55440

merged 1 commit into from
Aug 15, 2024

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 9, 2024

Fixes #55235

Disables the assertion failure in the scheduler, so that we are more likely to be able to report the underlying failure and run atexit handlers successfully. This should clean up some of the error messages that occur on timeout.

julia> sleep(5)
^\
[89829] signal 3: Quit: 3
in expression starting at REPL[1]:1
kevent at /usr/lib/system/libsystem_kernel.dylib (unknown line)
unknown function (ip: 0x0)
Allocations: 830502 (Pool: 830353; Big: 149); GC: 1
Quit: 3

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Aug 14, 2024
@vtjnash vtjnash merged commit 67c1723 into master Aug 15, 2024
4 of 7 checks passed
@vtjnash vtjnash deleted the jn/55235 branch August 15, 2024 12:57
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Aug 15, 2024
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Aug 17, 2024
Fixes JuliaLang#55235

Disables the assertion failure in the scheduler, so that we are more
likely to be able to report the underlying failure and run atexit
handlers successfully. This should clean up some of the error messages
that occur on timeout.
```
julia> sleep(5)
^\
[89829] signal 3: Quit: 3
in expression starting at REPL[1]:1
kevent at /usr/lib/system/libsystem_kernel.dylib (unknown line)
unknown function (ip: 0x0)
Allocations: 830502 (Pool: 830353; Big: 149); GC: 1
Quit: 3
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure in Scheduler code
2 participants