REPLCompletions: allow completions for explicitly using-ed names
#54610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/using-completion
branch
from
a8c9a86 to
135a048
Compare
aviatesk
commented
May 29, 2024
aviatesk
force-pushed
the
avi/36529
branch
4 times, most recently
from
edb44e5 to
9f2e685
Compare
aviatesk
force-pushed
the
avi/using-completion
branch
from
65581ed to
e11ebd7
Compare
|
This doesn't fix #53999, the second submodule in a line like is still not completed. |
The new feature `usings=true` added to `names` enhances REPL completions by allowing explicitly `using`-ed names to be found. ```julia julia> using Base: @assume_effects julia> @assu| # completes to `@assume_effects` ``` As a result, the implementation of REPL completions has been simplified. Additionally, it allows completion for names that are implicitly or explicitly `using`-ed in code specifying a module explicitly, such as: ```julia julia> module A end julia> A.signi| # completes to `A.significand` ``` - fixes #29275 - fixes #40356 - fixes #49109 - fixes #53524
aviatesk
force-pushed
the
avi/using-completion
branch
from
e11ebd7 to
9c307ff
Compare
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
…uliaLang#54610) The new feature `usings=true` added to `names` enhances REPL completions by allowing explicitly `using`-ed names to be found. ```julia julia> using Base: @assume_effects julia> @assu| # completes to `@assume_effects` ``` As a result, the implementation of REPL completions has been simplified. Additionally, it allows completion for names that are implicitly or explicitly `using`-ed in code specifying a module explicitly, such as: ```julia julia> module A end julia> A.signi| # completes to `A.significand` ``` - fixes JuliaLang#29275 - fixes JuliaLang#40356 - fixes JuliaLang#49109 - fixes JuliaLang#53524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new feature
usings=trueadded tonamesenhances REPL completions by allowing explicitlyusing-ed names to be found.As a result, the implementation of REPL completions has been simplified. Additionally, it allows completion for names that are implicitly or explicitly
using-ed in code specifying a module explicitly, such as:using#53524fixes [REPL] Autocompletion ofusingmultiple submodules is broken #53999