Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompilepkgs: don't confuse single package in project with requesting single package #53865

Conversation

IanButterworth
Copy link
Member

Followup to #53653
Separate from #53862 because this one is just broken on master

Without this if you precompile a project with a single dep it thought the user was calling precompile Dep or using Dep so went into live print mode, which is confusing.

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Mar 26, 2024
@IanButterworth IanButterworth merged commit 653c0ae into JuliaLang:master Mar 26, 2024
8 checks passed
@IanButterworth IanButterworth deleted the ib/precompilepkgs_fix_single_case branch March 26, 2024 23:22
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant