Document LazyString in performance tips #53779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassepe
force-pushed
the
docs/LazyString
branch
from
8f1a4e9 to
644adea
Compare
Zentrik
reviewed
Mar 18, 2024
lassepe
force-pushed
the
docs/LazyString
branch
from
644adea to
65fdf45
Compare
aviatesk
approved these changes
Mar 19, 2024
|
@aviatesk those are interesting additional details. But I think they are best added to the docstring of |
|
Yep, it's fine. |
|
Is there anything left to do before this can be merged? |
|
Could you fix the CI build failure? It seems to be caused by this PR. |
lassepe
force-pushed
the
docs/LazyString
branch
from
65fdf45 to
02d46f9
Compare
|
All done. I think the remaining breakage is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says. Doc-changes only.
Recent motivating example: FluxML/Flux.jl#2399