Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Juliaup docs #50477

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Add Juliaup docs #50477

merged 10 commits into from
Feb 13, 2024

Conversation

davidanthoff
Copy link
Contributor

No description provided.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think this is a really important step.

doc/src/manual/installation.md Outdated Show resolved Hide resolved
doc/src/manual/installation.md Outdated Show resolved Hide resolved
@@ -0,0 +1,12 @@
# [Juliaup](@id man-juliaup)

Juliaup is the official installer for Julia, enabling you to easily update and switch between Julia versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file really be here? It seems to me it would make more sense to have a dedicated Juliaup manual, part of the Juliaup repository https://github.com/JuliaLang/juliaup and then link to that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think from a user point of view I really dislike it when documentation is spread-out, e.g. the fact that the Pkg.jl docs aren't just in the Julia manual in my mind is really not user friendly. Sooo, I think it would be really much better if the docs are just part of the Julia manual, way easier to find for users. BUT, I'm going to remove this for now, so that we can at least merge the first part of this PR here.

doc/src/manual/installation.md Outdated Show resolved Hide resolved
@brenhinkeller brenhinkeller added the docs This change adds or pertains to documentation label Aug 4, 2023
@IanButterworth
Copy link
Member

@davidanthoff perhaps if there are sections of this that need further work, they could be deferred to a followup PR?
Better to have this in the manual on master and get more eyes on it?

@davidanthoff davidanthoff marked this pull request as ready for review February 2, 2024 22:39
@davidanthoff
Copy link
Contributor Author

@IanButterworth, yes, lets merge what is done, and I'll open a new PR with more docs later. This is now ready for review.

@inkydragon
Copy link
Member

CI error

Whitespace check found 1 issues:
doc/src/manual/installation.md -- non-UNIX line endings

Comment on lines +118 to +122
To install Julia via Rust's cargo, run:

```sh
cargo install juliaup
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text says: "To install Julia via Rust's cargo, run:" but then gives a command to install juliaup. A non-experienced reader at this point might expect Julia to already be installed.

How about this:

Suggested change
To install Julia via Rust's cargo, run:
```sh
cargo install juliaup
```
To install Juliaup via Rust's cargo, run:
```sh
cargo install juliaup
```
Afterwards run `juliaup` -- you may pass any of the command line arguments described above.

I guess the same also applies to the OpenSUSE and (home)brew sections -- and to a degree also the Arch one, which correctly states that it describes how to install Juliaup, but the user reading this wants to install Julia.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some language at the top of the alternative methods section, I think that might be good enough?

In any case, I think we should just merge this at this point, and then folks can open follow up PRs that refine the lanugage.

@fingolfin fingolfin merged commit 288912a into JuliaLang:master Feb 13, 2024
3 of 7 checks passed
@davidanthoff davidanthoff deleted the da/juliaup-docs branch February 13, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants