Improve handling of LLVM function attributes #49597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM does this already.
maleadt
added
compiler:codegen
vtjnash
reviewed
May 2, 2023
| @@ -410,9 +408,6 @@ bool removeAddrspaces(Module &M, AddrspaceRemapFunction ASRemapper) | |||
| } | |||
| NF->setAttributes(Attrs); | |||
|
|
|||
| if (F->hasPersonalityFn()) | |||
| NF->setPersonalityFn(MapValue(F->getPersonalityFn(), VMap)); | |||
There was a problem hiding this comment.
looks like this was indeed fixed 8 years ago llvm/llvm-project@2ac0c27
oscardssmith
removed
the
merge me
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #49551: Instead of copying attributes manually, just ensure we always call
CloneFunctionInto, as it does useful work for declarations too (bailing out early, https://github.com/llvm/llvm-project/blob/33017e5a3fa2c3194522565cd0e106a931b072b3/llvm/lib/Transforms/Utils/CloneFunction.cpp#L144-L147). This includes mapping of the personality function, https://github.com/llvm/llvm-project/blob/33017e5a3fa2c3194522565cd0e106a931b072b3/llvm/lib/Transforms/Utils/CloneFunction.cpp#L111-L115, so we can get rid of that too.x-ref #49551 (comment)