(re-)allow include_dependency(directory) #49244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow using a directory for
include_dependency(path)
to track whether any file or subdirectory is added.This was working fine (for Oscar.jl) in Julia 1.6 and 1.8 but since #47184 (in master and 1.9) the cache file is rejected with the following error and a fresh precompilation is triggered every time Oscar is loaded:
Here
experimental
is a subfolder where developers can add extra code that will then be picked up without adding all files explicitly to some list in the main Oscar sources.I am aware that the docs for
include_dependency
only mentionfile
, I understoodfile
here in a more file-system oriented way and not strictly asregular file
, similar to how it is used in the docs forstat
.I adjusted the docs for
include_dependency
accordingly and clarified that this uses the mtime ofpath
.cc: @lkastner
x-ref: oscar-system/Oscar.jl#2203