remove svec(#null) from the language #46975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not supported, and almost never used, so audit all places it could happen and avoid it at the source. Fix #46784
Keno
reviewed
Sep 29, 2022
Keno
reviewed
Sep 29, 2022
| for (i = 0; i < sz; i++) { | ||
| assert(jl_is_unionall(ub)); | ||
| // TODO: assert(env[i] != NULL); | ||
| if (env[i] == NULL) |
There was a problem hiding this comment.
Did you mean to put this before/during assigning to the svec?
There was a problem hiding this comment.
Uncertain, since if this ever happens, it is because intersection/subtyping made a mistake. This is just there to avoid that mistake causing Julia to crash.
Co-authored-by: Keno Fischer <[email protected]>
vtjnash
commented
Sep 30, 2022
vtjnash
commented
Sep 30, 2022
vtjnash
commented
Sep 30, 2022
| return ccall(:jl_svec_len, Int, (Any,), v) | ||
| t = @_gc_preserve_begin v | ||
| len = unsafe_load(Ptr{Int}(pointer_from_objref(v))) | ||
| @_gc_preserve_end t |
There was a problem hiding this comment.
@Keno is our inlining smart enough to insert this _gc_preserve_end automatically when required?
vtjnash
added a commit
that referenced
this pull request
Dec 5, 2023
aviatesk
pushed a commit
that referenced
this pull request
Dec 6, 2023
aviatesk
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not supported, and almost never used, so audit all places it could happen and avoid it at the source.
Fix #46784