sparam inlining: Handle undefined sparams #46703
Conversation
`_compute_sparams` is not required to be able to resolve an sparam, it can leave it as a `TypeVar`, in which case accessing it should throw an UndefVarError. This needs to be appropriately handled in inlining. We have a test case like this in the test suite, but it was being papered over by an incorrect check in can_inline_typevar. Remove that check and implement proper undef checking in inlining.
Keno
force-pushed
the
kf/sparamundef
branch
from
89cd963 to
e730590
Compare
Keno
added
the
needs pkgeval
|
This is subtle enough that we should run a PkgEval over it. Unfortunately, PkgEval is currently broken. |
|
Thanks, I knew that |
|
@nanosoldier |
|
Your package evaluation job has completed - possible issues were detected. A full report can be found here. |
|
I'm looking into the PkgEval issues and will re-trigger when fixed. |
|
Turns out the @nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
|
PkgEval seems clean |
_compute_sparamsis not required to be able to resolve an sparam, it can leave it as aTypeVar, in which case accessing it should throw an UndefVarError. This needs to be appropriately handled in inlining. We have a test case like this in the test suite, but it was being papered over by an incorrect check in can_inline_typevar. Remove that check and implement proper undef checking in inlining.