Revert #43641

[ericphanson]

Reverts #43641 as discussed there and in #44016

[vtjnash]

As you mentioned on that PR though, it seem we do expect it to support minlevel and other standard logger features such as maxlog

[ericphanson]

Hm ok :). Do we want to keep #43641 then? Do we want this additionally? I do think it's useful on it's own. Maybe I should make these two separate PRs so they can be discussed individually.

[ericphanson]

Ok, I made this PR just the revert and pulled the other commit out to #44080.

And then I guess maybe we should close this if we want a TestLogger to act kind of like a usual logger, supporting maxlog and minlevel? cc @fredrikekre

[fredrikekre]

And then I guess maybe we should close this if we want a TestLogger to act kind of like a usual logger, supporting maxlog and minlevel?

Lets make respecting max log optional, just like the min level then? By default I think it should capture everything, but if you want to test something else you can configure it.

[ericphanson]

Lets make respecting max log optional, just like the min level then?

Sure, do you think just respect_maxlog=true in the constructor and store the bool in the struct?

[fredrikekre]

Yea, something like that.

[ericphanson]

Closing in favor of #44085