Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use open to open Julia REPL in macOS default terminal #43111

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

Evian-Zhang
Copy link
Contributor

Most macOS developers use third-party terminal apps (e.g. iTerm2) to replace macOS's default terminal. Current implementation will always open built-in terminal to execute Julia REPL, which is not good enough. By using open command, macOS will automatically use the user-default terminal to execute Julia executable

Most macOS developers use third-party terminal apps (e.g. iTerm2) to replace macOS's default terminal. Current implementation will always open built-in terminal to execute Julia REPL, which is not good enough.
@ViralBShah ViralBShah added the system:mac Affects only macOS label Nov 17, 2021
@ViralBShah
Copy link
Member

This seems nice! Would be nice if we can get quick reviews from folks who know more about applescript than me.

@oscardssmith oscardssmith added the forget me not PRs that one wants to make sure aren't forgotten label Nov 17, 2021
@simonbyrne
Copy link
Contributor

Ah, that's very nice! It seems to work correctly for me. Do you know what determines this? Previously we had looked at different things but came to the conclusion that Mac OS didn't have the notion of a default terminal (#24906).

@simonbyrne
Copy link
Contributor

Ah, it seems to be due to the LSHandlerContentType "public.unix-executable":
https://apple.stackexchange.com/a/60599

@simonbyrne simonbyrne merged commit 0ca6948 into JuliaLang:master Nov 18, 2021
@ViralBShah
Copy link
Member

Will this work reliably on older releases of macOS from about 2013 or so?

@simonbyrne
Copy link
Contributor

I would think so (the link above is from 2011), but I'm not sure how we could check.

@ViralBShah
Copy link
Member

ViralBShah commented Nov 18, 2021

I suppose we have adequate time to test this out over the 1.8 release cycle. In the worst case, it should at least open Julia in Terminal.

LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
)

Most macOS developers use third-party terminal apps (e.g. iTerm2) to replace macOS's default terminal. Current implementation will always open built-in terminal to execute Julia REPL, which is not good enough.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
)

Most macOS developers use third-party terminal apps (e.g. iTerm2) to replace macOS's default terminal. Current implementation will always open built-in terminal to execute Julia REPL, which is not good enough.
@DilumAluthge DilumAluthge removed the forget me not PRs that one wants to make sure aren't forgotten label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants