Indexing arrays with AbstractUnitRanges retains indices #40660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.6
On master:
This happens because #39896 changed the behavior of
getindex
, and it now uses the length of the indices instead of the axes to generate the output array. This PR reverts this to make the result account for the axes again. After this:Also,
on master
After this PR (back to v1.6 behavior):
The performance impact on changing
unsafe_copyto!
tocopyto!
appears to be minimal.with
copyto!
with
unsafe_copyto!
The difference is within the noise level.