Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to compilecache so that Pkg precompilation can not skip different versions of loaded modules #40345

Merged
merged 3 commits into from
Apr 8, 2021
Merged

add option to compilecache so that Pkg precompilation can not skip different versions of loaded modules #40345

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58dbd2c
allow Pkg precomp to not skip loaded modules
IanButterworth Apr 3, 2021
4ec2438
rename to ignore_loaded_modules
IanButterworth Apr 6, 2021
0075396
arg alignment
IanButterworth Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,16 +1303,20 @@ end

const MAX_NUM_PRECOMPILE_FILES = Ref(10)

function compilecache(pkg::PkgId, path::String, internal_stderr::IO = stderr, internal_stdout::IO = stdout)
function compilecache(pkg::PkgId, path::String, internal_stderr::IO = stderr, internal_stdout::IO = stdout,
ignore_loaded_modules::Bool = true)
IanButterworth marked this conversation as resolved.
Show resolved Hide resolved

@nospecialize internal_stderr internal_stdout
# decide where to put the resulting cache file
cachepath = compilecache_dir(pkg)

# build up the list of modules that we want the precompile process to preserve
concrete_deps = copy(_concrete_dependencies)
for (key, mod) in loaded_modules
if !(mod === Main || mod === Core || mod === Base)
push!(concrete_deps, key => module_build_id(mod))
if ignore_loaded_modules
for (key, mod) in loaded_modules
if !(mod === Main || mod === Core || mod === Base)
push!(concrete_deps, key => module_build_id(mod))
end
end
end
# run the expression and cache the result
Expand Down