Make RemoteChannel iterable #33555
Closed
Make RemoteChannel iterable #33555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
iteration
|
bump 🙂 |
|
Seems like something we should clearly do. The only issue is the implementation. Does this approach seem good to you, @JeffBezanson? |
|
Is this ready to go, @tkf? |
findmyway
approved these changes
Aug 19, 2021
tkf
commented
Aug 19, 2021
| try | ||
| return (take!(c), nothing) | ||
| catch e | ||
| if isa(e, InvalidStateException) && e.state == :closed |
There was a problem hiding this comment.
isa(e, InvalidStateException) is not enough.
We'd need to handle the case when the channel is a reference
julia> ch = RemoteChannel(workers()[end])
RemoteChannel{Channel{Any}}(2, 1, 8)
julia> put!(ch, 1)
RemoteChannel{Channel{Any}}(2, 1, 8)
julia> close(ch)
julia> take!(ch)
1
julia> err = try
take!(ch)
catch err
err
end
RemoteException(2, CapturedException(InvalidStateException("Channel is closed.", :closed), Any[(check_channel_state at channels.jl:170 [inlined], 1), (take_buffered at channels.jl:388, 1), (take! at channels.jl:383, 1), (take! at remotecall.jl:599,
1), (take_ref at remotecall.jl:610, 1), (#106 at process_messages.jl:278, 1), (run_work_thunk at process_messages.jl:63, 1)
, (macro expansion at process_messages.jl:278 [inlined], 1), (#105 at task.jl:411, 1)]))
|
#41966 is an alternative solution to this |
|
Replaced by (included in) #41966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being an iterator is one of the nice features of Channel. Can RemoteChannel have it?
close #31177