Stop exporting dot from LinearAlgebra.BLAS #31878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinearAlgebra exports the familiar `dot` function. The BLAS submodule has its own `dot` function, which it also exports, leading to problems if a user tries to access `dot` after `using` both LinearAlgebra and BLAS. Because this conflict currently exists, this change should be non-breaking, as it's difficult to resolve `dot` unqualified from BLAS before it's resolved from LinearAlgebra, so pretty much any consumer must already calling `BLAS.dot` as such. Fixes #31838.
ararslan
added
linear algebra
fredrikekre
approved these changes
Apr 30, 2019
|
@staticfloat: any idea what's up with these failures? |
|
musm
reviewed
Apr 30, 2019
| @@ -15,7 +15,6 @@ export | |||
| axpy!, | |||
| axpby!, | |||
| blascopy!, | |||
| dot, | |||
There was a problem hiding this comment.
maybe just comment it out, so it's clear that it's no longer exported ?
#dot ?
Not so difficult, but I agree that most everyone who is using this is probably just calling julia> using LinearAlgebra.BLAS
julia> dot(3, [1.,2,3], 1, [1.,2,3], 1)
14.0 |
StefanKarpinski
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinearAlgebra exports the familiar
dotfunction. The BLAS submodule has its owndotfunction, which it also exports, leading to problems if a user tries to accessdotafterusingboth LinearAlgebra and BLAS.Because this conflict currently exists, this change should be non-breaking, as it's difficult to resolve
dotunqualified from BLAS before it's resolved from LinearAlgebra, so pretty much any consumer must already callingBLAS.dotas such.Fixes JuliaLang/LinearAlgebra.jl#626.