Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for month constants #31218

Merged
merged 6 commits into from
Mar 14, 2019
Merged

Update documentation for month constants #31218

merged 6 commits into from
Mar 14, 2019

Conversation

eulerkochy
Copy link
Contributor

Addresses a part of #31202

@kshyatt kshyatt added docs This change adds or pertains to documentation dates Dates, times, and the Dates stdlib module labels Mar 1, 2019
cormullion
cormullion reviewed Mar 1, 2019
View reviewed changes
Copy link
Contributor

@cormullion cormullion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"abrreviation" -> "abbreviation"

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Mar 3, 2019 •
edited
Loading

Documenting each month individually is kind of amusing but we do want to document everything so 👍

@eulerkochy
Copy link
Contributor Author

I wanted to opt for metaprogramming but there were far too many cases to consider for each month, so I adopted this simple, yet exhaustive method!

@StefanKarpinski
Copy link
Member

That works. We're unlikely to get any more months any time soon.

@StefanKarpinski
Copy link
Member

I'm a little surprised that these are just integer constants and not some kind of Month object but I that's how it was before this PR so documenting them doesn't make anything worse.

@eulerkochy
Copy link
Contributor Author

Any more work remaining on this PR? Just curious 😉

@StefanKarpinski
Copy link
Member

@quinnj, does this look good to you?

@eulerkochy
Copy link
Contributor Author

Bump

@StefanKarpinski StefanKarpinski merged commit cc1caa4 into JuliaLang:master Mar 14, 2019
raphbacher pushed a commit to raphbacher/julia that referenced this pull request Mar 19, 2019
@eulerkochy
Dates: docstrings for month constants (JuliaLang#31218)
669aad8
@dkarrasch dkarrasch mentioned this pull request Mar 31, 2019
Closed
@kshyatt kshyatt mentioned this pull request Apr 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormullion cormullion cormullion left review comments

@StefanKarpinski StefanKarpinski StefanKarpinski left review comments

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eulerkochy @StefanKarpinski @cormullion @fredrikekre @kshyatt