Change eigvals(::Number) to return a scalar #27730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal for how eigvals could return a scalar when given a scalar input, in line with what svdvals does. (See issue #27687) Promotion to float is also skipped. (Just like svdvals, eigvals will now return an integer for scalar real integer input.) For complex scalar input, the return type will depend on whether the imaginary component is zero, as before. Since Julia allows indexing into, and iterating over, a scalar as if it were a length-1 vector, this change should have minimal effect on existing code.
perrutquist
changed the title
andreasnoack
added
linear algebra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for how
eigvalscould return a scalar when given a scalar input, in line with whatsvdvalsdoes. (This avoids allocating a vector to store just one element.) See issue JuliaLang/LinearAlgebra.jl#536Promotion to float is also skipped. Just like
svdvals,eigvalswill now return anIntegerfor a scalarIntegerinput. For aComplexscalar input, the return type will depend on whether the imaginary component is zero, as before.Since Julia allows indexing into and iterating over a scalar as if it were a length-1 vector, existing code that assumes that a vector is returned will likely continue to work.