add a deprecate_stdlib macro that binds to the right functions #25692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
Jan 23, 2018
base/deprecated.jl
Outdated
| @eval @deprecate_moved $(Symbol("@sprintf")) "Printf" true true | ||
|
|
||
| # PR #21709 | ||
| @deprecate cov(x::AbstractVector, corrected::Bool) cov(x, corrected=corrected) |
There was a problem hiding this comment.
The below was certainly not planned to be removed
vchuravy
force-pushed
the
vc/stdlib_deprecations
branch
2 times, most recently
from
58803f6 to
fc01c4d
Compare
|
Ok this is good to go from my side. |
vchuravy
commented
Jan 24, 2018
base/bitarray.jl
Outdated
| @@ -431,7 +431,7 @@ end | |||
|
|
|||
| function copyto!(dest::BitArray, src::Array) | |||
| length(src) > length(dest) && throw(BoundsError(dest, length(dest)+1)) | |||
| length(src) == 0 && return det | |||
| length(src) == 0 && return dest | |||
There was a problem hiding this comment.
sneaky... I will split this out and make a separate PR.
There was a problem hiding this comment.
@code_warntype copyto!(BitArray([true]), [1])
....
end::Union{typeof(Base.det), BitArray{1}}lol...
There was a problem hiding this comment.
I now understand how Jameson found this:
WARNING: Base.det is deprecated: it has been moved to the standard library package `LinearAlgebra`.
Add a `using LinearAlgebra` to your imports..
in module Base
in copyto! at bitarray.jl
152343a to
e463b6b
Compare
|
Absent any further objections I plan to merge this this evening (EST) |
- New `deprecate_stdlib` macro that adds user friendly deprecation for bindings that have been moved to the stdlib, but are still in the sysimage. - Simplify `deprecate_moved` macro. - add deprecation for BLAS submodule Also-by: Jameson Nash <[email protected]>
vchuravy
force-pushed
the
vc/stdlib_deprecations
branch
from
e463b6b to
cf729a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long anticipated followup to #24843. Since we actually have the stdlib modules in the sysimage
we can deprecate correctly and still point to the right functions.
Turns
into:
This still leads to: