only allow certain characters after interpolated vars #25234
Conversation
|
Seems there's some trailing whitespace that snuck into |
| @@ -258,3 +258,6 @@ end | |||
| # added ⟂ to operator precedence (#24404) | |||
| @test Meta.parse("a ⟂ b ⟂ c") == Expr(:comparison, :a, :⟂, :b, :⟂, :c) | |||
| @test Meta.parse("a ⟂ b ∥ c") == Expr(:comparison, :a, :⟂, :b, :∥, :c) | |||
|
|
|||
| # only allow certain characters after interpolated vars (#25231) | |||
| @test Meta.parse("\"\$x෴ \"",raise=false) == Expr(:error, "interpolated variable \$x ends with invalid character \"෴\"; use \"\$(x)\" instead.") | |||
There was a problem hiding this comment.
෴ (U+0df4) looks just like my signature 😉 .
src/julia-parser.scm
Outdated
| @@ -2073,7 +2073,7 @@ | |||
| (string.join (string-split s a) b)) | |||
|
|
|||
| (define (ends-interpolated-atom? c) | |||
| (or (opchar? c) (never-identifier-char? c))) | |||
| (or (eof-object? c) (opchar? c) (never-identifier-char? c))) | |||
There was a problem hiding this comment.
I don't really understand this – is there a test case?
There was a problem hiding this comment.
Yes, the replcompletions test exercises this; the issue was that you need Base.incomplete_tag(Meta.parse("\"\$foo", raise=false)) to return :string.
If you don't check eof-object? here, then parsing the incomplete string "$foo will raise a syntax error for because $foo is terminated by an eof, instead of raising an incomplete error.
There was a problem hiding this comment.
I suppose we could add an explicit @test Base.incomplete_tag(Meta.parse("\"\$foo", raise=false)) == :string too.
There was a problem hiding this comment.
Ah, makes sense. Can't hurt to have the explicit test here.
This closes #25231.
That is, an interpolated variable
$xin a string literal must be followed by a character in a set S of codepoints that will never be allowed in an identifier. Currently, S = { spaces/control chars, ASCII/Latin1 non-connector punctuation,`}.