Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-stabilize broadcast over tuples and scalars #21331

Merged
merged 1 commit into from
Apr 9, 2017

Conversation

pabloferz
Copy link
Contributor

No description provided.

@pabloferz
Copy link
Contributor Author

The only problem with this would be the codegen for large tuples, but that should be fixed on the ntuple end anyway.

@ararslan ararslan added the broadcast Applying a function over a collection label Apr 8, 2017
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloferz, this change looks great! Addressing the potential code blowup issue in ntuple sounds like a good plan if possible; perhaps something like the Any16 trick for map over tuples would serve?

@nanosoldier runbenchmarks(ALL, vs = ":master")

@Sacha0 Sacha0 added the performance Must go faster label Apr 8, 2017
@Sacha0
Copy link
Member

Sacha0 commented Apr 8, 2017

Ref. #20817 (comment), which this change might address by using ntuple(..., Val{N}) rather than ntuple(..., n).

@pabloferz
Copy link
Contributor Author

Seems like @nanosoldier cannot be triggered from a review summary.

@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@Sacha0
Copy link
Member

Sacha0 commented Apr 9, 2017

The sole possible regression nanosoldier identified is almost certainly noise. Cheers!

@pabloferz pabloferz merged commit 7c1e5af into JuliaLang:master Apr 9, 2017
@pabloferz pabloferz deleted the pz/stable-bctup branch April 9, 2017 16:36
ajkeller34 referenced this pull request in PainterQubits/Unitful.jl May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants