Fix axpy! and add tests. #15407
Merged
Fix axpy! and add tests. #15407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also some of the tests in the file kinda don't make sense especially for axpy! where |
| # test that LinAlg.axpy! works for x and y of different dimensions | ||
| let | ||
| α = 5 | ||
| x = ones(Int, 2, 3) |
There was a problem hiding this comment.
probably use x = 2:7 or similar, so that the test checks that the right elements of x are being added to y.
|
LGTM. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in LinAlg.axpy! and added test. Fixes JuliaLang/LinearAlgebra.jl#315.
Is it convention for tests to explicit say
Base.LinAlg.axpy!vsLinAlg.axpy!?