Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing GC root in table.c #15318

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Fix missing GC root in table.c #15318

merged 1 commit into from
Mar 2, 2016

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Mar 2, 2016

This is the second GC (usage) bug discovered while investigating #15271. This has a higher chance to be the real cause since I can see how some recent change can put a higher pressure on the ObjectIdDict rehashing... (OTOH, it seems to be as old as 2011/2010 and I'm surprised that no one have hit it before.....)

@tkelman backport 0.4 might need to remove the dump.c part. (the change in dump.c is only a comment now so it should be easy to backport.) Let me know if it is not straight foward when doing the backport.

@colbec If you can try to see if this fixes the issue.

@yuyichao yuyichao added GC Garbage collector backport pending 0.4 labels Mar 2, 2016
@yuyichao yuyichao force-pushed the yyc/gc/table-realloc branch from 577ff94 to 27faae4 Compare March 2, 2016 02:39
@yuyichao
Copy link
Contributor Author

yuyichao commented Mar 2, 2016

Local GC stress test on subarray passes 11 times (8x release, 3x debug) where as it segfaults 6 out of 6 times with debug build before. Will wait for a few more test runs and merge this later today to see if it helps #15271.

@carnaval
Copy link
Contributor

carnaval commented Mar 2, 2016

thanks a lot man :-) those bugs really are the nastiest

@timholy
Copy link
Member

timholy commented Mar 2, 2016

Whether it fixes the problem or not, this is awesome @yuyichao.

@colbec
Copy link

colbec commented Mar 2, 2016

@yuyichao FYI I have been running tests (about 10 today with testall) and not seen the issue. I am currently on Version 0.5.0-dev+2975 (2016-03-02 15:55 UTC) and will keep testing at a frequency higher than I would normally to see if I can see the issue again. Clearly it puts a burden on my machine and cycles, but I have noted the interest in the issue and will do what I can to support the team effort.

yuyichao added a commit that referenced this pull request Mar 2, 2016
@yuyichao yuyichao merged commit 7abfee8 into master Mar 2, 2016
@yuyichao yuyichao deleted the yyc/gc/table-realloc branch March 2, 2016 18:47
@tkelman
Copy link
Contributor

tkelman commented Mar 2, 2016

Thanks for keeping an eye out @colbec! When I'm running tests repeatedly I like to do something like

for i in `seq 20`; do
  make testall || break
done

@yuyichao
Copy link
Contributor Author

yuyichao commented Mar 2, 2016

I usually add a mail <email address> before the break.

@yuyichao yuyichao mentioned this pull request Mar 3, 2016
2 tasks
tkelman pushed a commit that referenced this pull request Mar 7, 2016
(cherry picked from commit 27faae4)
ref #15318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants