Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method that produces error for prod(AbstractArray{Bool}). #14659

Merged
merged 1 commit into from
Jan 13, 2016

Conversation

andreasnoack
Copy link
Member

Fixes #14657

andreasnoack added a commit that referenced this pull request Jan 13, 2016
Remove method that produces error for prod(AbstractArray{Bool}).
@andreasnoack andreasnoack merged commit 5cbb72c into master Jan 13, 2016
@andreasnoack andreasnoack deleted the anj/booldet branch January 13, 2016 20:03
@tkelman
Copy link
Contributor

tkelman commented Jan 13, 2016

could use a more direct test of this signature, particularly its return type

@tkelman tkelman added the needs tests Unit tests are required for this change label Jan 13, 2016
@andreasnoack
Copy link
Member Author

Do you mean something like prod([true,true,true])===true?

@tkelman
Copy link
Contributor

tkelman commented Jan 14, 2016

right. the bitunpack test would work if you check the return type.

I think this is borderline for backporting, it would be really easy to write code that doesn't work on early 0.4.x versions with this change.

@andreasnoack
Copy link
Member Author

I've put the modified test back

it would be really easy to write code that doesn't work on early 0.4.x versions with this change.

Isn't that true for most bug fixes? Feel free to do what you think is best.

@tkelman
Copy link
Contributor

tkelman commented Jan 14, 2016

Yes, but what I want to avoid is having Pkg.update() break users' code. So package authors need to be very careful with REQUIRE any time they add code that would fail on existing 0.4.x releases. Ideally packages would test against earlier point releases in addition to the latest. Upgrading julia between point releases is intended to be non breaking and easy to do, but might not always be under the user's control.

@tkelman tkelman removed the needs tests Unit tests are required for this change label Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants