Use Ref{BlasInt} instead of Vector{BlasInt} for lapack info return. #14522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks. there's still a leftover |
|
Haha. The |
|
the asymmetry of the diff stuck out |
Fix method error with LAPACK 3.6.0 in svd test.
yuyichao
force-pushed
the
yyc/lapack-info-ref
branch
from
e72621e to
5459d33
Compare
yuyichao
added a commit
that referenced
this pull request
Jan 1, 2016
Use Ref{BlasInt} instead of Vector{BlasInt} for lapack info return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was to fix method error with LAPACK 3.6.0 in svd test (the old
chklapackerrorfunction cannot handleRef) and I figured that I may as well consistently useRefinstead ofVector's forinfosince they are much better.@andreasnoack