Do not assume the GC is always running on the master thread. #14278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
added
multithreading
|
👍 |
yuyichao
force-pushed
the
yyc/gc/cleanup
branch
from
f2b666e to
35bfdfc
Compare
yuyichao
force-pushed
the
yyc/gc/cleanup
branch
from
35bfdfc to
d43226c
Compare
|
lgtm |
yuyichao
added a commit
that referenced
this pull request
Dec 6, 2015
Do not assume the GC is always running on the master thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus clean up.
We can't wait for thread 0 or pause it to run GC because it might be waiting for a OS level lock or executing other non-reentrant libc functions (
malloc,printffor example).